+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41016/34539

• This PR adds an extra 764KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Adding all geometries and the FullRecoGPU for Patatrack wfs for Phase2  #41011, Add run3 tracking low pu era #33532, Displaced regional tracking iteration #40643

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• Configuration/HLT (hlt)
• Configuration/PyReleaseValidation (pdmv, upgrade)
• HLTrigger/Configuration (hlt)

@Martin-Grunewald, @AdrianoDee, @bbilin, @cmsbuild, @missirol, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @silviodonato, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

test parameters:

• pull_requests = Update L1 menu tag for data RelVals and 2023/2024, Phase2 MC GTs #41005
• workflows = 139.004,140.003,140.023,140.043,140.063,12634.0,12634.99,12834.0,13034.0,13034.99
• enable = gpu

@cmsbuild , please test

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ecffd/31172/summary.html
COMMIT: 6ea9301
CMSSW: CMSSW_13_1_X_2023-03-09-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41016/31172/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 28 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 135 differences found in the comparisons
• DQMHistoTests: Total files compared: 59
• DQMHistoTests: Total histograms compared: 4751113
• DQMHistoTests: Total failures: 1145
• DQMHistoTests: Total nulls: 95
• DQMHistoTests: Total successes: 4749851
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 76689.64400000001 KiB( 58 files compared)
• DQMHistoSizes: changed ( 12634.0,... ): -0.328 KiB L1T/L1TStage2uGT
• DQMHistoSizes: changed ( 11634.0,... ): 9818.210 KiB HLT/BTV
• DQMHistoSizes: changed ( 11634.0,... ): 1531.818 KiB HLT/EXO
• DQMHistoSizes: changed ( 11634.0,... ): 1187.008 KiB HLT/TOP
• DQMHistoSizes: changed ( 11634.0,... ): 1130.035 KiB HLT/HIG
• DQMHistoSizes: changed ( 11634.0,... ): 1056.366 KiB HLT/JME
• DQMHistoSizes: changed ( 11634.0,... ): 344.597 KiB HLT/Objects
• DQMHistoSizes: changed ( 11634.0,... ): 152.027 KiB HLT/TAU
• DQMHistoSizes: changed ( 11634.0,... ): 117.172 KiB HLT/EGM
• DQMHistoSizes: changed ( 11634.0,... ): -57.377 KiB HLT/Filters
• DQMHistoSizes: changed ( 11634.0 ): ...
• Checked 256 log files, 206 edm output root files, 59 DQM output files
• TriggerResults: found differences in 13 / 57 workflows

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 53 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19862
• DQMHistoTests: Total failures: 335
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19527
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: found differences in 3 / 3 workflows

+hlt

• The changes in the outputs of PR tests are in line with the updates to the HLT menus used in the 20(22|23|24) MC RelVals and Run-3 data RelVals.

• The Phase-2 wfs are unaffected by this PR (and #41005). Still, they show spurious differences in the JetMET/{Jet,MET}Validation folders (e.g. wf 20900.0). This is reminiscent of #39754, and most likely unrelated to this PR or #41005 (in fact, such differences are not seen in the tests of #41005 (comment), which included this PR).

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2

Could you please prioritise the review of this PR (and its backport)?

The latest GT updates by AlCa (#41005) require this HLT PR to be integrated.

+Upgrade

+pdmv

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cms-sw/orp-l2

This PR is ready for your review.

This PR and #41005 need to be integrated in the same IB.

+1

Also merging #41005